Skip to content

feat: make pr e2e use shared actions and add tests - #52

Draft
mhdawson wants to merge 8 commits into
rh-ai-quickstart:mainfrom
mhdawson:rh-qs-test-suite-pr-e2e
Draft

mhdawson wants to merge 8 commits into
rh-ai-quickstart:mainfrom
mhdawson:rh-qs-test-suite-pr-e2e

Conversation

@mhdawson

Copy link
Copy Markdown
Member
  • update rh-qs-test-suite skill so that the workflow genereated
    for pr e2e testing uses the shared actions from quickstart-ci-testing
  • add tests for the generation of pr e2e workflow
  • remove static copy of shared actions in test harness directories and
    dynamically copy to shared location at start of test to avoid having
    to update every time the shared actions change
  • skill tweaks to address issues found

- tweak nightly-test-prompt in rh-qs-test-suite to assume main if no git info
- adjust expected location of pipeline files due to changes in quickstart factory

Signed-off-by: Michael Dawson <midawson@redhat.com>
- add tests for build and build workflow generation
- tweaks to fix issues found along the way

Signed-off-by: Michael Dawson <midawson@redhat.com>
- additional tests for rh-qs-test-suite focussed on creation of core pr test
  workflow
- fixes found while building/running tests
- fixes found when testing on 2 quickstartttts
Signed-off-by: Michael Dawson <midawson@redhat.com>
- add tests for create-dev-to-main-pr.yml and tweak for issues found along the way
- add tests for pr-branch-check.yml and tweak for issues found along the way
- add creation of workflow to bump quickstart version to rh-qs-test-suite and add assoccciated tests

Signed-off-by: Michael Dawson <midawson@redhat.com>
- update rh-qs-test-suite skill so that the workflow genereated
  for pr e2e testing uses the shared actions from quickstart-ci-testing
- add tests for the generation of pr e2e workflow
- remove static copy of shared actions in test harness directories and
  dynamically copy to shared location at start of test to avoid having
  to update every time the shared actions change
- skill tweaks to address issues found

Signed-off-by: Michael Dawson <midawson@redhat.com>
@github-actions

Copy link
Copy Markdown

🔍 Skill Validation (Advisory — does not block merge)

⚠️ Warnings

  • unknown directory: subagents/ (contains 3 files) — agents using the standard skill structure won't discover these files; should this be assets/?
  • unexpected file at root: output-templates.md — if agents need this file, move it into references/ or assets/ as appropriate; otherwise remove it to avoid unnecessary context window usage
  • unexpected file at root: reasoning-guardrails.md — if agents need this file, move it into references/ or assets/ as appropriate; otherwise remove it to avoid unnecessary context window usage
  • unknown directory: runners/ (contains 8 files) — agents using the standard skill structure won't discover these files; should this be assets/?
  • unexpected file at root: spec-template.md — if agents need this file, move it into references/ or assets/ as appropriate; otherwise remove it to avoid unnecessary context window usage
  • unknown directory: subagents/ (contains 4 files) — agents using the standard skill structure won't discover these files; should this be assets/?

📋 Full report

Signed-off-by: Michael Dawson <midawson@redhat.com>
@github-actions

Copy link
Copy Markdown

🔍 Skill Validation (Advisory — does not block merge)

⚠️ Warnings

  • unknown directory: subagents/ (contains 3 files) — agents using the standard skill structure won't discover these files; should this be assets/?
  • unexpected file at root: output-templates.md — if agents need this file, move it into references/ or assets/ as appropriate; otherwise remove it to avoid unnecessary context window usage
  • unexpected file at root: reasoning-guardrails.md — if agents need this file, move it into references/ or assets/ as appropriate; otherwise remove it to avoid unnecessary context window usage
  • unknown directory: runners/ (contains 8 files) — agents using the standard skill structure won't discover these files; should this be assets/?
  • unexpected file at root: spec-template.md — if agents need this file, move it into references/ or assets/ as appropriate; otherwise remove it to avoid unnecessary context window usage
  • unknown directory: subagents/ (contains 4 files) — agents using the standard skill structure won't discover these files; should this be assets/?

📋 Full report

Signed-off-by: Michael Dawson <midawson@redhat.com>
@github-actions

Copy link
Copy Markdown

🔍 Skill Validation (Advisory — does not block merge)

⚠️ Warnings

  • unknown directory: subagents/ (contains 3 files) — agents using the standard skill structure won't discover these files; should this be assets/?
  • unexpected file at root: output-templates.md — if agents need this file, move it into references/ or assets/ as appropriate; otherwise remove it to avoid unnecessary context window usage
  • unexpected file at root: reasoning-guardrails.md — if agents need this file, move it into references/ or assets/ as appropriate; otherwise remove it to avoid unnecessary context window usage
  • unknown directory: runners/ (contains 8 files) — agents using the standard skill structure won't discover these files; should this be assets/?
  • unexpected file at root: spec-template.md — if agents need this file, move it into references/ or assets/ as appropriate; otherwise remove it to avoid unnecessary context window usage
  • unknown directory: subagents/ (contains 4 files) — agents using the standard skill structure won't discover these files; should this be assets/?

📋 Full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant